Partial fix for bug 1488

[royfalk]

Ammo will not add mass or volume. This includes missiles.
This is a temporary fix for now. Ideally, we should refactor both mounts and turrets.
However, this is a major undertaking.

Closes #1488

Code Changes:

• Have the PR Validation Tests been run? See https://github.com/vegastrike/Vega-Strike-Engine-Source/wiki/Pull-Request-Validation. Tested bug fix only and some stuff around it.

Issues:

• Ammo should have mass and volume.
• Guns have ammo. Missiles are ammo. Not sure how the game handles the dissonance.

[kheckwrecker]

I'm unable to confirm whether this has resolved the issue or not, as I'm now unable to purchase any ammo or weapons at all for the Dostoevsky. Everything under ammo and weapons shows up in Ship Upgrade in purple, including the dumbfire ammo.

[royfalk]

I'm unable to confirm whether this has resolved the issue or not, as I'm now unable to purchase any ammo or weapons at all for the Dostoevsky. Everything under ammo and weapons shows up in Ship Upgrade in purple, including the dumbfire ammo.

Well that's not good. Are you starting from a new game and buying a clean Dostoevsky?

[kheckwrecker]

I started from a new game and bought a clean Dostoevsky. I also started from an older saved game and purchased a clean Dostoevsky. I was unable to purchase dumbfire missiles in either scenario.

[royfalk]

Hmm. Looks like this is more complicated.
Weapons in general shouldn't count toward upgrade volume, as they are all mounted on dedicated hard points.
But, the game also has some kind of calculation for missile mounts - you can fit several light missiles in a medium mount.
Need some more tweaking.

[royfalk]

Accidentally committed to task_fix_1411 and not here.
Two main issues remain:

1. Need to check we've covered all possibilities for upgrades.
2. Number of missiles upgrades is a weird function of mount sizes (really a bit field). This hack produces inconsistent but plausible results. For example, Dostoevsky buys a light missile. light missile size is 64. Missile mount size is light (64) + medium (128) + heavy (256). Result is seven missiles.