Fix bug 1411 - purchase of cargo was crashing #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as volume was 0 and there was a div by 0 error.
royfalk
requested review from
BenjamenMeyer,
evertvorster,
kheckwrecker and
stephengtuggy
| // Check the maximum you can fit in your hold, but only if volume != 0 | ||
| if(item->GetVolume() > 0) { | ||
| int max_stackable_quantity = static_cast<int>(std::floor(hold->AvailableCapacity() / item->GetVolume())); | ||
| quantity = std::min(max_stackable_quantity, quantity); |
Member
There was a problem hiding this comment.
shouldn't this also have a std::max with 0 so it doesn't go negative?
Contributor
Author
There was a problem hiding this comment.
So this is a bit complex. We have a 'mult_shady_moreupgrade' upgrade, which could show up as negative volume but for now is implemented as volume=0.1.
In reality, if we have a negative volume for actual upgrades, this will have issues elsewhere as well.
Better to fix this properly in cargo.
Member
There was a problem hiding this comment.
while I agree we should fix it elsewhere too, we should also protect ourselves here as well.
- Prevent weapons from costing upgrade volume - Refactor concluseTransaction - Remove superfluous upgradeNotAddedToCargo function.
Contributor
Author
|
Last commit belongs in task_fix_1488. Reverting. |
This reverts commit c3b14b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as volume was 0 and there was a div by 0 error.
Closes #1411
Code Changes: