Add an automatic module name to the MANIFEST

[LonelyMidoriya]

Summary by CodeRabbit

• Chores
  • Updated packaging metadata across multiple modules to add Automatic-Module-Name entries in JAR manifests (feature-reporting, metadata-fixer, validation-model, wcag-validation).
  • Bumped parent project version to 1.29.6.
  • No changes to runtime behavior, public APIs, or application logic.

[coderabbitai]

Walkthrough

Four module POMs were updated to add a maven-jar-plugin configuration that writes an Automatic-Module-Name into each JAR manifest (org.verapdf.feature.reporting, org.verapdf.metadata.fixer, org.verapdf.validation.model, org.verapdf.wcag.validation). The top-level pom.xml parent version was bumped from 1.29.1 to 1.29.6. No source code or runtime behavior changed.

Changes

Cohort / File(s)	Summary
Maven JAR Plugin Configuration (Automatic-Module-Name manifest entries) feature-reporting/pom.xml, metadata-fixer/pom.xml, validation-model/pom.xml, wcag-validation/pom.xml	Added maven-jar-plugin under build/plugins with archive/manifestEntries/Automatic-Module-Name set to each module's unique identifier. No behavioral, dependency, or source-code changes.
Parent POM version bump pom.xml	Updated parent POM version from 1.29.1 to 1.29.6. No other changes shown.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify each Automatic-Module-Name value exactly matches intended module identifiers.
• Confirm plugin block placement/syntax is consistent across the four POMs.
• Validate the parent version bump is intentional and compatible with module requirements.

Poem

🐰 I hopped through POMs with a tiny cheer,
Names tucked in manifests, tidy and clear.
Parent bumped gently, packages aligned,
No code disturbed — just labels refined. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Add an automatic module name to the MANIFEST' directly and clearly summarizes the primary change across all modified files, which consistently add Automatic-Module-Name entries to JAR manifests via Maven configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch automatic-module-name

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb4b160 and b09d9f4.

📒 Files selected for processing (5)

• feature-reporting/pom.xml (1 hunks)
• metadata-fixer/pom.xml (1 hunks)
• pom.xml (1 hunks)
• validation-model/pom.xml (1 hunks)
• wcag-validation/pom.xml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• validation-model/pom.xml
• feature-reporting/pom.xml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Checkout and Build (17)
• GitHub Check: Checkout and Build (21)

🔇 Additional comments (3)

pom.xml (1)

31-31: Verify the parent POM version bump from 1.29.1 to 1.29.6.

The version jump spans three minor releases. Confirm that:

• This version exists and is stable
• There are no breaking changes in the parent that would affect the modules
• All modules are compatible with this parent version

wcag-validation/pom.xml (1)

66-78: maven-jar-plugin configuration looks good.

The Automatic-Module-Name is correctly set to org.verapdf.wcag.validation, following the reverse-DNS naming convention and consistent with the module's artifactId. The configuration will enable Java Module System support for this module.

Verify that the same pattern is consistently applied across all four modules mentioned in the PR (feature-reporting, metadata-fixer, validation-model, and wcag-validation).

metadata-fixer/pom.xml (1)

61-73: maven-jar-plugin configuration aligns with other modules.

The Automatic-Module-Name is correctly set to org.verapdf.metadata.fixer, maintaining consistency with the naming pattern established in other modules. The configuration is identical in structure to wcag-validation/pom.xml, which is appropriate.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

validation-model/pom.xml (1)

77-89: Automatic-Module-Name configuration is correct; version management should be addressed codebase-wide.

The Automatic-Module-Name metadata addition is valid and follows Java 9+ module naming conventions. However, verification confirms that the maven-jar-plugin lacks version management in the parent POM—a pattern affecting four modules: validation-model, feature-reporting, metadata-fixer, and wcag-validation. While this change doesn't introduce the issue, consider adding <version>3.3.0</version> (or the latest stable version) to all four modules' maven-jar-plugin configurations to ensure reproducible builds, or define it centrally in the parent's <pluginManagement> section.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c71801c and c6e5dff.

📒 Files selected for processing (4)

• feature-reporting/pom.xml (1 hunks)
• metadata-fixer/pom.xml (1 hunks)
• validation-model/pom.xml (1 hunks)
• wcag-validation/pom.xml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Checkout and Build (25)
• GitHub Check: Checkout and Build (11)
• GitHub Check: Checkout and Build (17)
• GitHub Check: Checkout and Build (8)

🔇 Additional comments (3)

feature-reporting/pom.xml (1)

78-92: Module name configuration is accurate and consistent.

The org.verapdf.feature.reporting module name is correctly configured and aligns with the module's purpose and artifact ID. Configuration structure matches the pattern applied across other modules in this PR.

wcag-validation/pom.xml (1)

66-78: WCAG module name configuration is correct.

The org.verapdf.wcag.validation module name properly identifies this module for Java 9+ modularity support and is consistently formatted with the other changes in this PR.

metadata-fixer/pom.xml (1)

61-73: Metadata Fixer module name configuration is correct and consistent with other modules.

The org.verapdf.metadata.fixer module name properly declares the module for Java 9+ support and follows the same configuration pattern as the other three modules in this PR.