Add support for string #13
Conversation
oscargus
force-pushed
the
string
branch
3 times, most recently
from
294c7c6 to
c9dd989
Compare
| ! ./vcddiff tests/counter.vcd tests/counter.time.no_diff.vcd | grep -q . | ||
| ! ./vcddiff tests/counter.vcd tests/counter.change_reorder.no_diff.vcd | grep -q . | ||
| ! ./vcddiff tests/counter.vcd tests/counter.var_reorder.no_diff.vcd | grep -q . | ||
| ! ./vcddiff tests/counter.vcd tests/counter.identifier.no_diff.vcd | grep -q . |
There was a problem hiding this comment.
Note that the file name here (and some more) was different than the actual, so the test passed as the "file not found" error was on stderr... I have renamed the files to correspond to the script.
|
Not sure how much to test, but added tests for changed identifier (which can be handled) and changed value (which provides output). It uses the same printing for string errors as for vector errors, but that is maybe OK? |
|
It should also be noted that spaces in strings must be escaped, typically as |
2 participants
Based on the discussion in verilator/verilator#6879
Will have to test a bit more before removing from draft.