Conversation
…cy controls - Add fail_on_api_error parameter (default: true) to control whether API connectivity/authentication errors block deployments - Remove fail_on_rejection parameter (redundant with server-side rule status) - Remove skip_preflight_checks parameter (replaced by server-side control per ADR-020) - Preflight rejections (409, 423, 428) now always fail - policy enforcement is controlled server-side via rule status (enabled, report_only, disabled) - API errors (401, 403, 404, 422, timeouts, connection errors) respect fail_on_api_error setting - Update documentation to explain server-side policy control approach - Add comprehensive test suite for new functionality This change provides cleaner separation of concerns: - Client controls: API connectivity issues (fail_on_api_error) - Server controls: Policy enforcement (rule status field) - No client-side policy override possible Related: versioner-dev-docs/tasks/fail-on-api-error-parameter.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cy controls
This change provides cleaner separation of concerns:
Related: versioner-dev-docs/tasks/fail-on-api-error-parameter.md
Description
Please include a summary of the changes and the related issue. Include relevant motivation and context.
Fixes # (issue)
Type of Change
Changes Made
Testing
Please describe the tests you ran to verify your changes.
npm test)npm run lint)npm run build)Checklist
dist/directoryScreenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any additional notes for reviewers here.