Update to main #73
Merged
Update to main #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bad reference to current_lob in before_lob_update
When processing AddOrderMessage or AddOrderMPIDMessage, add the order_ref to self._order_refs so subsequent message handlers (executions, cancels, deletes, replacements) can properly track and process orders for this instrument. Without this fix, _order_refs remained empty and all subsequent handlers would exit early, causing the limit order book to not be updated correctly. Fixes #68 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…instead of price The ITCH 5.0 OrderExecutedPriceMessage class uses `execution_price` as its attribute name, but the code was incorrectly referencing `message.price`. This fixes the AttributeError when processing OrderExecutedPriceMessage. Fixes #69 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…emessage-object-has-no-attribute-price Fix AttributeError: OrderExecutedPriceMessage has no attribute 'price'
…d-not-executed-because-self_order_refs-is-not-updated fix: populate _order_refs when processing AddOrderMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.