Feature/room color persistence and improvements#2
Open
abbinavv wants to merge 3 commits intovinayakchandra:mainfrom
Open
Feature/room color persistence and improvements#2abbinavv wants to merge 3 commits intovinayakchandra:mainfrom
abbinavv wants to merge 3 commits intovinayakchandra:mainfrom
Conversation
## New Features
- RoomColorManager: Singleton for saving/loading room element colors
- Persists colors to Documents/RoomColors/{roomName}_colors.json
- Supports walls, floors, doors, windows, tables, chairs, storage
- Colors persist across app restarts and mode switches
- Save button in Edit mode (replaces standalone + button)
- Captures thumbnail with current colors
- Saves to Documents/RoomThumbnails/{roomName}_thumb.jpg
- Shows success alert and navigates to home screen
- Add furniture button still available (blue +)
- Color picker improvements
- Native Cancel and Done buttons in navigation bar
- Cancel restores previous colors
- Done confirms selection
- Thumbnail improvements
- MyRoomsViewController loads saved colored thumbnails
- Falls back to QuickLook if no saved thumbnail exists
## Bug Fixes
- Fixed BillboardComponent crash (EXC_BAD_ACCESS)
- Safe cleanup in viewWillDisappear
- Async setting of BillboardComponent on main thread
- Proper removal before entity cleanup
- Fixed PhotogrammetrySession.Request.Detail enum
- Changed .preview/.medium/.full to .reduced (iOS 26 SDK)
- Updated quality selector UI to reflect available options
- Fixed Swift 6 main actor isolation warnings in BackgroundModelProcessor
## New Files
- Envision/Managers/RoomColorManager.swift
- Envision/Managers/BackgroundModelProcessor.swift
- Envision/Tips/TipPresenter.swift
- PROJECT_WORKFLOW.md
- RECOMMENDED_IMPROVEMENTS.md
- AR_MEASUREMENT_TOOL_IMPLEMENTATION_PLAN.md
- COMPLETE_TECHNICAL_DOCUMENTATION.md
- FIREBASE_BACKEND_IMPLEMENTATION_PLAN.md
- TIPS_TOUR_IMPROVEMENT_PLAN.md
## Modified Files
- RoomEditVC.swift: Save button, color persistence, thumbnail capture
- RoomVisualizeVC.swift: Load and apply saved colors
- MyRoomsViewController.swift: Load saved thumbnails
- VisualizeRoomViewController.swift: BillboardComponent fix, color picker
- RoomARWithFurnitureViewController.swift: BillboardComponent fix
- ObjectCapturePreviewController.swift: Quality selector fix, cancel button
- BackgroundModelProcessor.swift: Main actor isolation fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tips removed currently , implemented some of the changes that was recommended.