Skip to content

avoid mutable default arguments #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quantifiedcode-bot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid mutable default arguments #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions haul/extenders/pipeline/google.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@

def blogspot_s1600_extender(pipeline_index,
finder_image_urls,
extender_image_urls=[],
extender_image_urls=None,
*args, **kwargs):
"""
Example:
http://1.bp.blogspot.com/-S97wTYQKbrY/UkWukhKhTKI/AAAAAAAAJ0g/fcRDiqVC8Us/s898/aaPOP+001.jpg
to
http://1.bp.blogspot.com/-S97wTYQKbrY/UkWukhKhTKI/AAAAAAAAJ0g/fcRDiqVC8Us/s1600/aaPOP+001.jpg
"""
if extender_image_urls is None:
extender_image_urls = []

now_extender_image_urls = []

Expand All @@ -32,14 +34,16 @@ def blogspot_s1600_extender(pipeline_index,

def ggpht_s1600_extender(pipeline_index,
finder_image_urls,
extender_image_urls=[],
extender_image_urls=None,
*args, **kwargs):
"""
Example:
http://lh4.ggpht.com/-fFi-qJRuxeY/UjwHSOTHGOI/AAAAAAAArgE/SWTMT-hXzB4/s640/Celeber-ru-Emma-Watson-Net-A-Porter-The-Edit-Magazine-Photoshoot-2013-01.jpg
to
http://lh4.ggpht.com/-fFi-qJRuxeY/UjwHSOTHGOI/AAAAAAAArgE/SWTMT-hXzB4/s1600/Celeber-ru-Emma-Watson-Net-A-Porter-The-Edit-Magazine-Photoshoot-2013-01.jpg
"""
if extender_image_urls is None:
extender_image_urls = []

now_extender_image_urls = []

Expand All @@ -59,14 +63,16 @@ def ggpht_s1600_extender(pipeline_index,

def googleusercontent_s1600_extender(pipeline_index,
finder_image_urls,
extender_image_urls=[],
extender_image_urls=None,
*args, **kwargs):
"""
Example:
https://lh6.googleusercontent.com/-T6V-utZHzbE/Ukjn-1MDOSI/AAAAAAAAA3g/H6Qcw1zt4n0/w555-h399-no/2101_aa2cac09d1c6431b8a635d61cd9c4471.jpg
to
https://lh6.googleusercontent.com/-T6V-utZHzbE/Ukjn-1MDOSI/AAAAAAAAA3g/H6Qcw1zt4n0/s1600/2101_aa2cac09d1c6431b8a635d61cd9c4471.jpg
"""
if extender_image_urls is None:
extender_image_urls = []

now_extender_image_urls = []

Expand Down
4 changes: 3 additions & 1 deletion haul/extenders/pipeline/pinterest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

def original_image_extender(pipeline_index,
finder_image_urls,
extender_image_urls=[],
extender_image_urls=None,
*args, **kwargs):
"""
Example:
Expand All @@ -15,6 +15,8 @@ def original_image_extender(pipeline_index,
to
http://media-cache-ec0.pinimg.com/originals/50/9b/bd/509bbd5c6543d473bc2b49befe75f4c6.jpg
"""
if extender_image_urls is None:
extender_image_urls = []

now_extender_image_urls = []

Expand Down
4 changes: 3 additions & 1 deletion haul/extenders/pipeline/tumblr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

def media_1280_extender(pipeline_index,
finder_image_urls,
extender_image_urls=[],
extender_image_urls=None,
*args, **kwargs):
"""
Example:
Expand All @@ -14,6 +14,8 @@ def media_1280_extender(pipeline_index,
to
http://25.media.tumblr.com/3f5f10d7216f1dd5eacb5eb3e302286a/tumblr_mtpcwdzKBT1qh9n5lo1_1280.png
"""
if extender_image_urls is None:
extender_image_urls = []

now_extender_image_urls = []

Expand Down
4 changes: 3 additions & 1 deletion haul/extenders/pipeline/wordpress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

def original_image_extender(pipeline_index,
finder_image_urls,
extender_image_urls=[],
extender_image_urls=None,
*args, **kwargs):
"""
Example:
Expand All @@ -15,6 +15,8 @@ def original_image_extender(pipeline_index,
http://fashion-fever.nl/wp-content/upload/2013/09/DSC_0058.jpg
http://www.wendyslookbook.com/wp-content/uploads/2013/09/Morning-Coffee-Run-7.jpg
"""
if extender_image_urls is None:
extender_image_urls = []

now_extender_image_urls = []

Expand Down
4 changes: 3 additions & 1 deletion haul/finders/pipeline/css.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

def background_image_finder(pipeline_index,
soup,
finder_image_urls=[],
finder_image_urls=None,
*args, **kwargs):
"""
Find image URL in background-image
Expand All @@ -15,6 +15,8 @@ def background_image_finder(pipeline_index,
to
http://distilleryimage10.ak.instagram.com/bde04558a43b11e28e5d22000a1f979a_7.jpg
"""
if finder_image_urls is None:
finder_image_urls = []

now_finder_image_urls = []

Expand Down
8 changes: 6 additions & 2 deletions haul/finders/pipeline/html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@

def img_src_finder(pipeline_index,
soup,
finder_image_urls=[],
finder_image_urls=None,
*args, **kwargs):
"""
Find image URL in <img>'s src attribute
"""
if finder_image_urls is None:
finder_image_urls = []

now_finder_image_urls = []

Expand All @@ -29,11 +31,13 @@ def img_src_finder(pipeline_index,

def a_href_finder(pipeline_index,
soup,
finder_image_urls=[],
finder_image_urls=None,
*args, **kwargs):
"""
Find image URL in <a>'s href attribute
"""
if finder_image_urls is None:
finder_image_urls = []

now_finder_image_urls = []

Expand Down
4 changes: 3 additions & 1 deletion tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,13 @@ def test_find_html_document(self):

def img_data_src_finder(pipeline_index,
soup,
finder_image_urls=[],
finder_image_urls=None,
*args, **kwargs):
"""
Find image URL in <img>'s data-src attribute
"""
if finder_image_urls is None:
finder_image_urls = []

now_finder_image_urls = []

Expand Down