fix: texture from surface buffer failed#606
Draft
asterwyx wants to merge 2 commits intovioken:masterfrom
Draft
Conversation
asterwyx
force-pushed
the
invalid-buffer
branch
from
219989c to
1e8ece8
Compare
Use client buffer's source as surface buffer. Client buffer is not complete, and might fail to get texture when the source buffer is a shm buffer.
Keep last non-null buffer for WSurfaceItemContent until explicitly destroyed.
asterwyx
force-pushed
the
invalid-buffer
branch
from
1e8ece8 to
971a803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use client buffer's source as surface buffer. Client buffer is not complete, and might fail to get texture when the source buffer is a shm buffer.