docs(modules/nebula.gl)!: restore to glory#512
docs(modules/nebula.gl)!: restore to glory#512charlieforward9 wants to merge 6 commits intomasterfrom
Conversation
These files had pre-existing formatting drift from the repo prettier config (arrow function parens, JSX attribute line wrapping, array formatting). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
In the past, we have decided to not include RFCs in the docs tree since they are not updated to reflect the latest status. Having these in the docs folder will make them indexable by the docs search which can be confusing. I.e. even if you leave them out of the table of contents, they are still there and can be searched and opened. |
|
I was under the impression you wanted this. I understand if you prefer to have a |
…md to docs/modules/editable-layers/developer-guide/rfc/nebula.md
…docs/modules/nebula/design-rfc.md
|
If you have any immediate pointers youd like to see made in editable-layers as I bring it back to nebula.gl - please chime in @georgioskarnas It would be great to take www.nebula.gl domain into visgl |
|
Firstly, this seems to contain both a restoration of a removed file and a bunch of code changes. Should it be split into two PRs? Just noting that the strong push you are driving to minimize directories in the root, while well-intended and valuable, is bringing up various issues: the directories that are being removed were there to avoid some practical issues / real concerns. On the RFC in docs folder topic:
General commentAt this point, I think the best compromise might be to accept one extra folder in the root (perhaps called
Mixing in outdated and half-finished files in the main directory structure will always raise concerns, some folks have very strong objections to including anything that is unfinished or confusing. |
|
To echo what I proposed during a previous call:
I have reduced the amount of PR's from ~60 to ~33, with a majority of them being your graph-layer changes. If we kept all the wip as PR's - and kept the active PR's lean - it would give anyone visiting an idea of what truly is in progress vs what is publicly available via npm or the examples. You did mention that navigating the git tree can become a hassle - which is why I am prioritizing keeping a clean PR list and attending to new ones as quickly - and agentically - as I can. |
Summary
docs/modules/nebula.gl/design-rfc.mdpreserving architectural rationale from the 4 original nebula.gl RFCs that were removed in chore: remove dead code and outdated WIP content #505Context
The
dev-docs/RFCs/editable-layers/directory was deleted in #505 with the message "implemented and no longer needed." While the interfaces are implemented, the RFCs contained valuable design rationale -- the "why" behind the architecture -- that was not captured anywhere in the current docs.Key content preserved:
ModeHandlerwas replaced, the framework-agnostic design intent, module boundary rationale (edit-modes has no deck.gl dependency), and the non-geospatial extensibility goalMulti*featuresThis is directly relevant to #496 (non-geospatial coordinate support), which references the Generic EditMode RFC by URL at the now-deleted commit.
Test plan
Relates to #496
Generated with Claude Code