Skip to content

Feature/editmode coordinate system 496#537

Open
eKerney wants to merge 2 commits intovisgl:masterfrom
eKerney:feature/editmode-coordinate-system-496
Open

Feature/editmode coordinate system 496#537
eKerney wants to merge 2 commits intovisgl:masterfrom
eKerney:feature/editmode-coordinate-system-496

Conversation

@eKerney
Copy link

@eKerney eKerney commented Feb 28, 2026

Related to RFC: Non-geospatial coordinate support for editable-layers #496
Discussion here at: feat(editable-layers): EditModeCoordinateSystem abstraction aligned with deck.gl COORDINATE_SYSTEM #516

Replaced TranslateMode with TranslateModeEx from @xinaesthete thank you!
Added OrthographicView, adjusted background image bounds and INITIAL_VIEW_STATE accordingly.
Added COORDINATE_SYSTEM.CARTESIAN to background and editableLayers.
Changed selected feature color to make more obvious to user.

Note: Running yarn start-local resulted in Failed to resolve import error, resolved by commenting line 22 in vite.config.local.mjs

'@deck.gl': join(rootDir, './node_modules/@deck.gl'),
no-map-editable.mp4

@charlieforward9
Copy link
Collaborator

Great proof of concept here - we certainly want to have the updated coordinate system be baked into the core modes - not create new ones per coordinate system - this would multiply our bug surface and make maintenance nearly impossible. Consider how we can update the current mode to work with non geo coordinates. or how we can pass the coordinate system into the core layer , or make a new master layer type EditableLayer that behaves like GeoJSON but isnt 'geo'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants