Fix continuing a chat session after tool calls caused a 400 Bad Request error from OpenAI API #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: as titled. caused by I rarely restoring previous sessions before so didnt notice this bug.
OpenAI's API have some restrictions, tool messages had timestamps from when they were executed (during permission handling), not when saved. When storage was sorted by timestamp, tool messages appeared before their parent assistant messages, creating invalid sequences for that API. When loading messages within the token budget, the truncation could include tool messages but exclude their parent assistant messages with
tool_calls.So timestamp sorting was removed, and added a workaround that add parent assistant message for orphaned tool messages.