input styling overrides input:not(.form-control) styling#97
Open
depaolif wants to merge 1 commit intovlad-ignatov:masterfrom
Open
input styling overrides input:not(.form-control) styling#97depaolif wants to merge 1 commit intovlad-ignatov:masterfrom
depaolif wants to merge 1 commit intovlad-ignatov:masterfrom
Conversation
…rol and no "input" prop provided; corrects label of input:not(.form-control) to describe input without form-control class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, users not using the "form-control" class on their input would have their "input" style prop being overridden by the "input:not(.form-control)" default styling. For instance, border and border-radius could not be changed using only the "input" style prop. The only way to style an input if not using bootstrap was to use "input:not(.form-control)" style prop. The label for "input:not(.form-control)" style was also incorrectly stated as "The input with bootstrap class".
This PR fixes this by only implementing "input:not(.form-control)" default styling if no "input" style prop is provided, making it much more intuitive to use. The typo for "input:not(.form-control)" is also corrected to "The input without bootstrap class".