handle round() with ndigits argument#39
Merged
medvednikov merged 1 commit intovlang:masterfrom Feb 20, 2026
Merged
Conversation
Python's round(x, ndigits) was dropping the second argument, producing math.round(x) instead of preserving decimal-place precision. round(3.14159, 2) produced 3.0 instead of 3.14. Uses math.round_sig(x, ndigits) for the two-argument form. Single-argument round(x) is unchanged. - visit_round() in plugins.v: dispatch on args.len for ndigits - 1 test expected output updated (abs_round) All 108 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's
round(x, ndigits)was dropping the second argument, producingmath.round(x)instead of preserving decimal-place precision.round(3.14159, 2)produced3.0instead of3.14.Changes
visit_round()inplugins.v: Dispatch onargs.len— two-argument form usesmath.round_sig(x, ndigits), single-argument form is unchangedabs_round)All 108 tests pass (0 skipped).