Skip to content

builder: fix json-errors windows path separator#25680

Merged
spytheman merged 3 commits intovlang:masterfrom
kbkpbot:fix-builder-json-error-windows-path
Nov 7, 2025
Merged

builder: fix json-errors windows path separator#25680
spytheman merged 3 commits intovlang:masterfrom
kbkpbot:fix-builder-json-error-windows-path

Conversation

@kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Nov 7, 2025

This PR fix json-errors message which will pass to vls.

This bug will cause json decode fail when the path is a windows path separator.

js=[
{
"path":"C:\Users\DDT\AppData\Local\Temp\atof.v",
"message":"unknown field `no_extra_char` in struct literal of type `strconv.AtoF64Param`.\nDid you mean `allow_extra_chars`?",
"line_nr":11,
"col":27,
"len":0
}
]

failed to parse json failed to decode JSON string: {
"path":"C:\Users\DDT\AppDat
run_v_check errors:[]

@kbkpbot
Copy link
Contributor Author

kbkpbot commented Nov 7, 2025

with vlang/vls#472, it make zed or vscode work under windows and linux.

Copy link
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kbkpbot .

@spytheman spytheman merged commit c40da32 into vlang:master Nov 7, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants