orm: add transaction API with savepoint-backed nesting#26707
Merged
medvednikov merged 3 commits intovlang:masterfrom Mar 9, 2026
Merged
orm: add transaction API with savepoint-backed nesting#26707medvednikov merged 3 commits intovlang:masterfrom
medvednikov merged 3 commits intovlang:masterfrom
Conversation
66 tasks
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41f89349ef
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an ORM-level transaction API in
vlib/orm. Checks off another task in #24931.New public API:
orm.begin(mut conn) !orm.Txorm.transaction(mut conn, fn (mut tx orm.Tx) !T) !Torm.Tximplementsorm.Connection, so existing ORM surfaces work inside transactions:sql tx { ... }!orm.new_query[T](tx)Nested transactions are implemented with savepoints rather than a second top-level transaction.
What changed
orm.TransactionalConnectionorm.Txandorm.Savepointorm.transaction(...)orm.begin(...)release_savepoint(...)support in the SQLite/MySQL/PostgreSQL backendsBehavior
Tx.commit()commits the DB transactionTx.rollback()rolls back the DB transactionTx.commit()releases the savepointTx.rollback()rolls back to the savepoint and releases itsql db {}blocksTests
Ran:
./vnew -silent test vlib/orm/./vnew vlib/db/sqlite/sqlite_test.v./vnew check-md vlib/orm/README.mdAlso compiled:
./vnew vlib/db/mysql/mysql_test.v./vnew vlib/db/pg/pg_test.v