cgen,autofree: don't clone array fn args in struct field init, add test#26709
cgen,autofree: don't clone array fn args in struct field init, add test#26709tankf33der wants to merge 1 commit intovlang:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d50f80510d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| is_fn_arg := field_type_sym.kind == .array && sfield.expr is ast.Ident | ||
| && sfield.expr.obj is ast.Var && (sfield.expr.obj as ast.Var).is_arg | ||
| if !is_fn_arg { |
There was a problem hiding this comment.
This new is_fn_arg fast path skips cloning for all array function arguments in struct literals, which changes ownership semantics beyond arrays.reverse_iterator. In -autofree, caller locals are still freed at scope end while generated struct free methods also free array fields, so code like fn wrap(a []int) S { return S{a:a} } with arr := [1]; s := wrap(arr) can now free the same backing buffer twice when both arr and s are cleaned up. The bypass should be limited to explicitly non-owning structs/fields instead of globally disabling gen_clone_assignment for arg-backed arrays.
Useful? React with 👍 / 👎.
|
Close/re-open to run CI with latest V. |
2 participants
Slightly changing the strategy — it will be more beneficial for everyone if
vlib/works in-autofreemode, rather thanexamples/; examples/ will then work on its own if everything is done correctly and in full.Right now all arrays in -autofree mode are cloned when placed into a
struct; this is my attempt to implement an exception so thatarrays.reverse_iterator()does not clone and it is possible to modify data in-place inside the loop.v -autofree test vlib/v/tests/structs/tests continue to pass successfully, just as before the patch.From now
v -autofree test vlib/arrays/reverse_iterator_test.vwill work in -autofree mode too.