Skip to content

UDP: refresh connection at the same time as the templates refresh #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jotak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

UDP: refresh connection at the same time as the templates refresh #434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d7460
UDP: refresh connection at the same time as the templates refresh
jotak Jul 4, 2025
407c539
concurrent-safe use of connection
jotak Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pkg/exporter/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ type templateValue struct {
// maxMsgSize is not set correctly, the message may be fragmented.
type ExportingProcess struct {
connToCollector net.Conn
connMut sync.Mutex
obsDomainID uint32
seqNumber uint32
templateID uint16
Expand Down Expand Up @@ -296,6 +297,17 @@ func InitExportingProcess(input ExporterInput) (*ExportingProcess, error) {
case <-expProc.stopCh:
return
case <-ticker.C:
// Dial again (e.g. host name resolving to a different IP)
klog.V(2).Info("Refreshing connection")
conn, err = net.Dial(input.CollectorProtocol, input.CollectorAddress)
if err != nil {
klog.Errorf("Cannot connect to the collector %s: %v", input.CollectorAddress, err)
} else {
expProc.connMut.Lock()
expProc.connToCollector = conn
expProc.connMut.Unlock()
}

klog.V(2).Info("Sending refreshed templates to the collector")
err := expProc.sendRefreshedTemplates()
if err != nil {
Expand Down Expand Up @@ -440,6 +452,8 @@ func (ep *ExportingProcess) closeConnToCollector() {
}
klog.Info("Closing connection to the collector")
close(ep.stopCh)
ep.connMut.Lock()
defer ep.connMut.Unlock()
if err := ep.connToCollector.Close(); err != nil {
// Just log the error that happened when closing the connection. Not returning error
// as we do not expect library consumers to exit their programs with this error.
Expand All @@ -450,6 +464,8 @@ func (ep *ExportingProcess) closeConnToCollector() {
// checkConnToCollector checks whether the connection from exporter is still open
// by trying to read from connection. Closed connection will return EOF from read.
func (ep *ExportingProcess) checkConnToCollector(oneByteForRead []byte) bool {
ep.connMut.Lock()
defer ep.connMut.Unlock()
ep.connToCollector.SetReadDeadline(time.Now().Add(time.Millisecond))
if _, err := ep.connToCollector.Read(oneByteForRead); err == io.EOF {
return false
Expand All @@ -475,6 +491,8 @@ func (ep *ExportingProcess) createAndSendIPFIXMsg(set entities.Set, buf *bytes.B
}

// Send the message on the exporter connection.
ep.connMut.Lock()
defer ep.connMut.Unlock()
bytesSent, err := ep.connToCollector.Write(buf.Bytes())

if err != nil {
Expand All @@ -499,6 +517,8 @@ func (ep *ExportingProcess) createAndSendJSONRecords(records []entities.Record,
bytesSent := 0
elements := make(map[string]interface{})
message := make(map[string]interface{}, 2)
ep.connMut.Lock()
defer ep.connMut.Unlock()
for _, record := range records {
clear(elements)
orderedElements := record.GetOrderedElementList()
Expand Down