Skip to content
This repository was archived by the owner on Jun 2, 2021. It is now read-only.

Conversation

@DecathectZero
Copy link
Member

Fixes or implements CORE-000

Brief description. What is this change?

I'm not sure why we have to construct a whole new workerpool every time we come across an expression? Can't we have a centralized one - this should help with the timeout issues

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

branch PR
other_pr_production link
other_pr_master link

Checklist

  • title of PR reflects the branch name
  • all commits adhere to conventional commits
  • appropriate tests have been written
  • all the dependendencies are upgraded

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #100 (ce13402) into master (c4359e1) will increase coverage by 0.28%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   72.28%   72.56%   +0.28%     
==========================================
  Files          36       36              
  Lines         855      853       -2     
  Branches      147      147              
==========================================
+ Hits          618      619       +1     
+ Misses        216      213       -3     
  Partials       21       21              
Impacted Files Coverage Δ
lib/Handlers/utils/shuntingYard.ts 33.14% <50.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4359e1...ce13402. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants