fix(bot): fix Telegram channel init crash and empty content for Claude#421
Open
ponsde wants to merge 2 commits intovolcengine:mainfrom
Open
fix(bot): fix Telegram channel init crash and empty content for Claude#421ponsde wants to merge 2 commits intovolcengine:mainfrom
ponsde wants to merge 2 commits intovolcengine:mainfrom
Conversation
TelegramChannel.__init__ references **kwargs in super().__init__() call, but kwargs is not in the method signature. This causes a NameError when the Telegram channel is instantiated, making it completely unusable. Also fixes the type hint from undefined TelegramConfig to the correct TelegramChannelConfig which is already imported.
…bility
When the LLM responds with only tool_calls and no text, content is None.
The expression `content or ""` produces an empty string, which Claude's
API rejects with 400 Bad Request ("text content blocks must be non-empty").
Only include the content field when it is non-empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs that prevent Telegram channel and Claude models from working correctly in vikingbot:
TelegramChannel.init NameError (
channels/telegram.py): Thesuper().__init__()call references**kwargs, butkwargsis not defined in the method signature. This causes an immediateNameErrorwhen the Telegram channel is instantiated, making it completely unusable. Also fixes the type hint from undefinedTelegramConfigto the already-importedTelegramChannelConfig.Empty content block rejected by Claude (
agent/context.py): When the LLM responds with onlytool_callsand no text,contentisNone. The expressioncontent or ""produces an empty string"", which Claude/Anthropic API rejects with400 Bad Request("text content blocks must be non-empty"). Fixed by only including thecontentfield when it is non-empty.Type of Change
Testing
Checklist