Skip to content

fix(a2a): normalize URL handling in RemoteVeAgent initialization #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yexuanyang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a2a): normalize URL handling in RemoteVeAgent initialization #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions veadk/a2a/remote_ve_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,22 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import json
import functools
import json
from typing import AsyncGenerator, Literal, Optional

from a2a.client.base_client import BaseClient
import httpx
import requests
from a2a.client.base_client import BaseClient
from a2a.types import AgentCard
from google.adk.agents.invocation_context import InvocationContext
from google.adk.agents.remote_a2a_agent import RemoteA2aAgent
from google.adk.events.event import Event
from google.adk.utils.context_utils import Aclosing

from veadk.integrations.ve_identity.utils import generate_headers
from veadk.utils.auth import VE_TIP_TOKEN_CREDENTIAL_KEY, VE_TIP_TOKEN_HEADER
from veadk.utils.logger import get_logger
from google.adk.utils.context_utils import Aclosing
from google.adk.events.event import Event
from google.adk.agents.invocation_context import InvocationContext


logger = get_logger(__name__)

Expand Down Expand Up @@ -140,7 +139,7 @@ def __init__(
httpx_client: Optional[httpx.AsyncClient] = None,
):
# Determine the effective URL for the agent and handle conflicts.
effective_url = url
effective_url = url.rstrip("/") if url else None
if httpx_client and httpx_client.base_url:
client_url_str = str(httpx_client.base_url).rstrip("/")
if url and url.rstrip("/") != client_url_str:
Expand Down Expand Up @@ -327,9 +326,10 @@ async def _inject_auth_token(self, ctx: InvocationContext) -> None:
return

try:
from veadk.utils.auth import build_auth_config
from google.adk.agents.callback_context import CallbackContext

from veadk.utils.auth import build_auth_config

# Inject TIP token via header
workload_auth_config = build_auth_config(
auth_method="apikey",
Expand Down