Vector extension simx with fallbacks for testcases and clean history #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@troibe I don't have git permissions to manually add you as a reviewer to this pull request, but as always any feedback/requested changes are appreciated! |
Added vector regression test to ci.yml
The vector tests need the cluster exitcodes
…aelJSr/vortex into riscv-vector-isa-simx-clean
tinebp
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive thanks to Troibe for his amazing work on the vector extension!
This is a fork of his work that has been updated to be up-to-date with the master branch, as well as adding regression testing, a bit more debug logging, and a few other modifications.
This pull request does not have the large vector testcases in the repository/history, and instead will download/copy the testcases from the submodule on demand. I was not sure how to remove only the commits from the history that added/modified the vector testcases without causing more issues, which is why this branch only has a single commit with just the changes. I will leave the previous branch(es) that have this history open in my fork just in case this history is needed. I hope this is acceptable, thanks in advance!