Skip to content

Fix Windows release artifact version number#10

Merged
vpoluyaktov merged 3 commits intomainfrom
fix_windows_build_version
Aug 11, 2025
Merged

Fix Windows release artifact version number#10
vpoluyaktov merged 3 commits intomainfrom
fix_windows_build_version

Conversation

@vpoluyaktov
Copy link
Owner

🐛 Bug Fix: Windows Release Artifact Missing Version Number

Problem

Windows release artifacts were missing the version number in the filename, showing as:

  • ❌ (double dash, missing version)
  • ✅ Should be:

Root Cause

The version extraction step was using bash parameter expansion which doesn't work consistently across all platforms, especially Windows in GitHub Actions.

Solution

  • Replaced bash parameter expansion with cross-platform command
  • Added explicit specification for consistency
  • Added debug output to show extracted version for troubleshooting

Changes Made

Extracted version:

Impact

  • ✅ Windows artifacts will now include proper version numbers
  • ✅ Consistent behavior across Windows, macOS, and Linux
  • ✅ Better debugging with version output
  • ✅ No impact on existing macOS/Linux functionality

Testing

This fix will be validated in the next release when all artifacts should show proper version numbers in their filenames.

- Fixed version extraction to use cross-platform sed instead of bash parameter expansion
- Added explicit bash shell specification for consistency across platforms
- Added debug output to show extracted version
- Resolves missing version number in Windows artifact filename
- Windows artifacts will now properly show: GitHub_Developer_Profiler-windows-v1.0.3-amd64.exe
@vpoluyaktov vpoluyaktov merged commit 1a675b9 into main Aug 11, 2025
6 checks passed
@vpoluyaktov vpoluyaktov deleted the fix_windows_build_version branch August 11, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant