Skip to content

Conversation

@edyespinal
Copy link
Contributor

@edyespinal edyespinal commented Aug 6, 2022

What problem is this solving?

Integration with easypost in order to create a return label.

How to test it?

Workspace

@edyespinal I couldn't tag you because you are a participant. Please take a look if you have time

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Aug 6, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ghost ghost requested a review from filafb August 29, 2022 10:38
Copy link
Collaborator

@filafb filafb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edyespinal @zekivtex Nice work! I added a couple of suggestions. Also, I didn't see anything on the store side. I think it would be nice to allow the store user to see the label in the interface.

Copy link
Collaborator

@filafb filafb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! The ReturnLabel component is way easier to read now! I added two comments to get your thoughts on them.

zipCode: String!
addressType: AddressType!
returnLabel: String
labelUrl: String
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key coming from MD and mapped on schema.json under masterdata builder is called returnLabel. In order to be consistent we should either change how we are saving it on masterdata or how we are declaring it on schema. I think the first one is the preferred one since, since changing schema on md can have side effects in the indexation process.

app: { settings },
} = installedApp

const { street1, street2, city, state, zip, country, name, phone } =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check if the settings has value? What does it return when the app is not installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants