fixes device_file issues with /sys path#1
Open
Tweeks-va wants to merge 24 commits intovtsman:masterfrom
Open
Conversation
fixed a ton of python code, updated slides
bad /sys path for device_file construction. Also had to define device_file as global (was throwing errors) Cleaned up white space.. left some ugly comments in there for you to look at close.. see whassup.
Author
|
This is to add the new slides (PDF and ooffice format) |
vtsman
approved these changes
Dec 7, 2016
vtsman
approved these changes
Dec 8, 2016
vtsman
approved these changes
Dec 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look at this spencer.. I'm not sure if this path changes much.. or why it worked for you before (on old hardware?). Anyway.. I fixed the path.. left he glob.glob in place with the 28* bc I had a hunch that 28* number is the device i2c device number?
Also had to make device_file global (was throwing error).
Also.. not in this code.. but check your ream_temp code vs what's in your slide.. the ordering of f & c returns are backwards (from the slide). So I left the code as is but changed the order in the slide to c,f matching your code.
Hope this all works.. lemme know.