feat(banners): add priority field and sort by priority DESC, created_at DESC #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

johnleider merged 7 commits into master from feat/banner-priority

Jan 29, 2026

Member

johnleider commented Jan 29, 2026

Summary

Adds priority support to banner system so important banners show first.

Changes

Add priority?: number to VOneBanner interface
Change banner selection from find() to filter() → sort() → take first
Sort banners by priority (high first), then by created_at (newest first)
Existing 3-day cooldown logic preserved

How it works

Banners with higher priority (2 > 1 > 0) show first
Among same priority, newest banner wins
Default priority is 0

Related

Requires CosmicJS field (already added by John)
API changes in separate PR

johnleider added 7 commits

January 29, 2026 10:53


          feat(banners): add priority field and sort by priority DESC, created_…

da192fa

…at DESC

- Add priority field to VOneBanner interface
- Change banner selection from find() to filter/sort/first
- Sort banners by priority (high first), then by created_at (newest first)
- Maintains existing cooldown logic (3 days)


          fix(banners): handle priority as object or number from CosmicJS

48da22f

CosmicJS returns radio button values as { key, value } objects.
Updated interface and sorting logic to handle both formats.


          fix(banners): also handle string priority values

d8b3cb4


          fix(banners): show all banners in dev mode regardless of site filter

e1caa07


          fix(banners): add spacing between text and action button

e547b67


          refactor(banners): use toSorted() instead of sort() to avoid mutation

13b602f


          style(banners): use function declaration for getPriority

4c9d885

johnleider merged commit c068300 into master

1 check passed

johnleider deleted the feat/banner-priority branch

January 29, 2026 17:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet