Conversation
Collaborator
NTTVy03
commented
Jan 6, 2025
NTTVy03
commented
- add missing signal assign token
- fix the grammar of the statement
- add statements test
- fix declaration, support matrix
- refactor declaration
- use list identity parser in the tuple
vuvoth
reviewed
Feb 4, 2025
| if let Some(token) = lookup_token_at_postion(&file, &program_ast, file.position(tmp)) { | ||
| println!( | ||
| "{:#?}", | ||
| lookup_node_wrap_token(TokenKind::TemplateDef, &token) |
Owner
There was a problem hiding this comment.
You can apply Insta here to snapshot output and use it for test later.
| let url = Url::from_file_path(Path::new("/hello/abc.tx")); | ||
| let binding = url.unwrap(); | ||
| let p = binding.path(); | ||
| println!("{:?}", Path::new(p).parent()); |
| | | | | SignalKw 174..180 | ||
| | | | | | SignalKw 174..180 "signal" | ||
| | | | | WhiteSpace 180..181 | ||
| | Error 1..2 |
Collaborator
Author
There was a problem hiding this comment.
Because you separate the test code into other file, the format is changed ('\r' character is added before '\n'). You can read more about '\r' here
I have fixed that.
Comment on lines
39
to
48
| | | | Identifier 56..58 | ||
| | | | | Identifier 56..58 "in" | ||
| | | | LBracket 58..59 | ||
| | | | | LBracket 58..59 "[" | ||
| | | | Expression 59..60 | ||
| | | | | Identifier 59..60 | ||
| | | | | | Identifier 59..60 | ||
| | | | | | | Identifier 59..60 "N" | ||
| | | | RBracket 60..61 | ||
| | | | | RBracket 60..61 "]" |
vuvoth
reviewed
Feb 6, 2025
| | BlockComment 2..25 | ||
| | | BlockComment 2..25 | ||
| | | | BlockComment 2..25 "/*\r\ncomment\r\nblocks\r\n*/" | ||
| | Error 25..26 |
Owner
|
We want to fix something. Let's merge this PR and create other PRs to solve this better. |
vuvoth
approved these changes
Feb 6, 2025
NTTVy03
added a commit
that referenced
this pull request
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.