Fix segfault on "lldptool -t -i eth2 -V PFC -c enabled"#1
Open
sowminiv wants to merge 1 commit intovvidic:masterfrom
Open
Fix segfault on "lldptool -t -i eth2 -V PFC -c enabled"#1sowminiv wants to merge 1 commit intovvidic:masterfrom
sowminiv wants to merge 1 commit intovvidic:masterfrom
Conversation
As per the lldptoo-pfc man page, I should be able to do
# lldptool -T -i eth2 -V PFC enabled=2
# lldptool -t -i eth2 -V PFC -c enabled
but I get a segfault at
0x000000000040a993 in get_arg_val_list (ibuf=0x7fffffffc2cd "07enabled",
ilen=14, ioff=0x7fffffffb12c, args=0x6163e0, argvals=0x6163c0)
at lldp_util.c:1239
:
Squinting at the code, looks like the *ioff check against ilen
in get_arg_val_list is trying to see if we are still within
the ibuff before moving args[] and argvals[] forward, so it
should not really be testing against arglen/argvalue_len.
Author
|
Seems like lldpad is now being updated by pull-requests, so trying that route. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the lldptoo-pfc man page, I should be able to do
lldptool -T -i eth2 -V PFC enabled=2
lldptool -t -i eth2 -V PFC -c enabled
but I get a segfault at
0x000000000040a993 in get_arg_val_list (ibuf=0x7fffffffc2cd "07enabled",
ilen=14, ioff=0x7fffffffb12c, args=0x6163e0, argvals=0x6163c0)
at lldp_util.c:1239
:
Squinting at the code, looks like the *ioff check against ilen
in get_arg_val_list is trying to see if we are still within
the ibuff before moving args[] and argvals[] forward, so it
should not really be testing against arglen/argvalue_len.