Closed
Conversation
mgax
force-pushed
the
feature/481-wagtail-newsletter
branch
3 times, most recently
from
440c232 to
c23960a
Compare
Because the `mrml` package doesn't work on Python 3.13 wagtail/wagtail-newsletter#69
mgax
force-pushed
the
feature/481-wagtail-newsletter
branch
from
c23960a to
317c68c
Compare
Member
Author
|
Closing in favour of #519. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481.
wagtail-newsletterand render some minimal MJMLNewsletterPagelooks goodwagtail-newsletterrecommends installing themrmllibrary to render MJML, but themrmlpackage doesn't work on Python 3.13 (wagtail/wagtail-newsletter#69), so we usemjml-python(another wrapper of the same underlying Rustmrmllibrary) for now.