Skip to content

Fix #508: Ensure consistent animations for logo cards#511

Open
Rish-it wants to merge 3 commits intowagtail:mainfrom
Rish-it:fix/508-logo-card-animations
Open

Fix #508: Ensure consistent animations for logo cards#511
Rish-it wants to merge 3 commits intowagtail:mainfrom
Rish-it:fix/508-logo-card-animations

Conversation

@Rish-it
Copy link

@Rish-it Rish-it commented Mar 25, 2025

  • Add position:relative to base logo-card class

  • Add transform transition for smoother animations

  • Move animation styles out of :is(a) selector

  • Apply animations consistently to all logo cards

- Add position:relative to base logo-card class

- Add transform transition for smoother animations

- Move animation styles out of :is(a) selector

- Apply animations consistently to all logo cards
@vossisboss
Copy link
Collaborator

Hello @Rish-it. I tested your proposed fix in both Firefox and Chrome. Unfortunately, it does not seem like the animation issue has been resolved. Here are some screenshots.

Screenshot 2025-03-26 at 6 15 10 PM

Screenshot 2025-03-26 at 6 13 05 PM

It's probably hard to test the fix yourself without access to the backend or test data for the Services page, so if you want to join our Slack community and coordinate with us in the #wagtail-org channel, we can probably get you paired up with someone who can help you with testing.

Please do give this another go if you want to and resubmit if you have another idea for how to fix this bug.

@Rish-it
Copy link
Author

Rish-it commented Mar 27, 2025

@vossisboss Thanks for testing the fix and sharing the screenshots. I appreciate the feedback. I’ll look and see if I can find a better solution. Since I’m already in the Slack channel, could you pair me up with someone who can help with testing? That would make debugging a lot easier.

…ces page

- Add animations to base card class

- Create services-specific styles for card section

- Ensure proper positioning context and transitions

- Apply the same hover effects across all card types
@Rish-it Rish-it force-pushed the fix/508-logo-card-animations branch from 998525f to 1aba133 Compare March 27, 2025 03:39
@vossisboss
Copy link
Collaborator

Hi @Rish-it. I actually discovered that something was up with my npmserver. So it looks like this fix is actually functional. My bad! Let me take a deeper look at this fix and see whether the changes you're proposing have any unexpected effects on other components.

I'll still connect you with some other folks in the Slack channel just in case you spot any other issues you want to try and fix.

@Rish-it
Copy link
Author

Rish-it commented Apr 2, 2025

@vossisboss Hey! No problem at all. Just checking in—did you get a chance to review the fix? Let me know if you ran into anything unexpected. Also, check your Slack DM when you get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants