Fix mobile menu toggle on touch devices#589
Open
AdityaSharma-Git3207 wants to merge 1 commit intowagtail:mainfrom
Open
Fix mobile menu toggle on touch devices#589AdityaSharma-Git3207 wants to merge 1 commit intowagtail:mainfrom
AdityaSharma-Git3207 wants to merge 1 commit intowagtail:mainfrom
Conversation
Signed-off-by: AdityaSharma-Git3207 <aadee.bharat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586
Fixes the mobile menu toggle not closing on touch devices.
The toggle was bound to
mousedown, which doesn’t reliably fire for subsequent taps on mobile browsers. This meant the menu could be opened but not closed again, leaving the navigation stuck open (and keeping page scroll locked).This switches the event handler to
pointerupfor more reliable touch interaction.