Skip to content

Conversation

@eywalker
Copy link
Contributor

Performed refactoring of codebase for simpler import hierarchry and add basic testing framework based on pytest

  • Use absolute import throughout the package. There appears to be no real concensus as to whether realtive import should be used or not (some interesting remarks here https://bugs.python.org/issue10031). As the structure of the package has become more complex, relative imports were getting quite counter intuitive, so I'm going to try making absolute imports throughout the package. Only exception to this is in __init__.py, where it is standard to do relative import.
  • Reorganized modules to minimize potential circular imports
  • Add implementation of Merge mapper as well as MergedQuerySource

@eywalker eywalker requested a review from brian-arnold May 24, 2025 05:20
@eywalker eywalker self-assigned this May 24, 2025
@eywalker eywalker added the enhancement New feature or request label May 24, 2025
@eywalker
Copy link
Contributor Author

Superseded by #14

@eywalker eywalker closed this May 24, 2025
@eywalker eywalker deleted the refactor branch May 27, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants