Skip to content

Conversation

@genosse-einhorn
Copy link

please note that this also removes compatibility with 3.4 and 3.6, you might want to reimplement my changes if you want to keep it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon, seems to have been missing though before these changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic semicolon insertion generally is a bitch but it has rendered this a non-issue. One should be more alarmed by the call to spawn_sync, since it may introduce lag if gnome-calculater needs some miliseconds to be launched and to calculate the expression.

@axeldavid
Copy link

Since @rgcjonas changed the version number in metadata.json (replaced "3.4", "3.6" with "3.8") these changes won't affect users with older versions of Gnome on extensions.gnome.org. They will simply be provided with the latest version of this extension that is compatible with their Gnome version. The lack of compatibility with Gnome 3.4 and 3.6 will therefore not be a problem.

I've tested these changes on my machine (Fedora 19 with Gnome 3.8) and it works like a charm without any errors or warnings to the log.

@war1025 I find your gnome extension very useful and this update would be much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants