Open
Conversation
For reproducible builds, set time stamps in CPIO files to a well defined value since these archives are distributed. (On reproducible builds: https://reproducible-builds.org/) Signed-off-by: Egbert Eich <eich@suse.com>
Author
|
The build errors in the CI seem to be unrelated to the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supersedes pull request #323:
There is a project under way to convince and help software projects to make their builds reproducible:
https://reproducible-builds.org/
openSUSE Factory is participating in this by attempting to make the entire build reproducible: https://en.opensuse.org/openSUSE:Reproducible_Builds. If packages contain files that may change between builds, these packages require changes. Since warewulf3 includes CPIO archives of an initramdisk there is a bit more effort involved in making the build reproducible: not only the file content but also the time stamps of the files in these archives matter. Moreover, cpio needs to be run with the option
--reproducible.Out tests have shown that by setting the access and modification time to a fixed reference value using touch is sufficient to make the resulting CPIO archives reproducible.