feat: implement recursive import expansion and type checking #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce recursive import expansion for codegen and strengthen type
safety in LLVM IR generation.
Changes:
- Import System:
- Refactor `local_import` to `local_import_unit`, returning both AST
and absolute path for recursive resolution.
- Implement `expand_imports_recursive` to flatten the dependency tree,
ensuring nested imports are correctly included in the final AST.
- Disable external imports (`foo::bar`) in standalone `wavec` mode.
- Skip `std::*` imports gracefully (placeholders for future stdlib).
- LLVM Codegen:
- Add strict type checking for function arguments in `FunctionCall`.
- Validate return types against expected types.
- Ensure variable initializers match declared types to prevent
implicit unsafe casts.
- Fix conditional branching logic in `if` statements:
- Explicitly compare integers/floats against zero to produce `i1`.
- Handle pointer null checks.
- Correctly terminate basic blocks to avoid LLVM verification errors.
- Runner:
- Integrate `expand_imports_for_codegen` into `run_wave_file`,
enabling multi-file compilation support.
- Config:
- Remove custom funding link.
This update enables modular project structures by supporting transitive
imports and improves compiler robustness with stricter type validation.
Signed-off-by: LunaStev <luna@lunastev.org>
Signed-off-by: LunaStev <luna@lunastev.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly upgrades the Wave compiler's ability to handle multi-file projects by implementing a recursive import expansion system. It also strengthens the LLVM backend with stricter type validation for functions and variables, ensuring that code generation is both robust and type-safe.
Key Changes
1. Recursive Import System
local_importintolocal_import_unit, which now tracks absolute paths to perform deep dependency tree flattening viaexpand_imports_recursive.foo::bar) when running in standalonewavecmode.std::*imports to serve as placeholders for the upcoming standard library.2. Enhanced LLVM Codegen & Type Safety
ifstatements by explicitly comparing integers and floats against zero to produce valid LLVMi1types.3. Runner & Infrastructure
run_wave_file, allowing the runner to compile projects spanning multiple.wavefiles.Technical Details
HashSetto prevent circular dependencies and redundant file processing.icmp/fcmp) for conditional expressions to maintain IR integrity.