Added a try/finally case for safety.#1
Open
magicbycalvin wants to merge 1 commit intowaveshare:masterfrom
Open
Added a try/finally case for safety.#1magicbycalvin wants to merge 1 commit intowaveshare:masterfrom
magicbycalvin wants to merge 1 commit intowaveshare:masterfrom
Conversation
Because the vehicle drives autonomously in the road_following.ipynb example, it is imperative to add safety features to it. As of right now, the only way to stop the vehicle is to send another car.throttle = 0 command. Stopping an autonomous vehicle under the duress of unexpected behavior can cause an individual to not think straight and therefore not realize that they can send the stopping command. Rather, the most common reaction would be to try and stop the kernel, unfortunately this still leaves the vehicle running with its last state. This is remedied by including the try/finally case which will guarantee that the vehicle comes to a stop if the infinite loop is interrupted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the vehicle drives autonomously in the road_following.ipynb example, it is imperative to add safety features to it. As of right now, the only way to stop the vehicle is to send another car.throttle = 0 command. Stopping an autonomous vehicle under the duress of unexpected behavior can cause an individual to not think straight and therefore not realize that they can send the stopping command. Rather, the most common reaction would be to try and stop the kernel, unfortunately this still leaves the vehicle running with its last state. This is remedied by including the try/finally case which will guarantee that the vehicle comes to a stop if the infinite loop is interrupted.