Skip to content

Fix yfinance-proxy start logic in quotron CLI#32

Merged
hunterjsb merged 1 commit intomainfrom
fix/yfinance-proxy-start-logic
Nov 17, 2025
Merged

Fix yfinance-proxy start logic in quotron CLI#32
hunterjsb merged 1 commit intomainfrom
fix/yfinance-proxy-start-logic

Conversation

@google-labs-jules
Copy link
Contributor

The quotron CLI was attempting to start the yfinance-proxy as a separate Python process, but the proxy has been integrated into the Go-based api-scraper. This change modifies the startYFinanceProxy function in the CLI's service manager to be a no-op, preventing it from trying to start the non-existent proxy. This resolves the test failures caused by the "connection refused" and "401 Unauthorized" errors.


PR created automatically by Jules for task 2406160525467598296 started by @hunterjsb

…eparate Python process, but the proxy has been integrated into the Go-based `api-scraper`. This change modifies the `startYFinanceProxy` function in the CLI's service manager to be a no-op, preventing it from trying to start the non-existent proxy. This resolves the test failures caused by the "connection refused" and "401 Unauthorized" errors.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@hunterjsb hunterjsb marked this pull request as ready for review November 17, 2025 01:34
@hunterjsb hunterjsb merged commit b10c5d8 into main Nov 17, 2025
1 check passed
@hunterjsb hunterjsb deleted the fix/yfinance-proxy-start-logic branch November 17, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant