Support Matroska MIME types in MediaRecorder #56759
Draft
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit support for `video/matroska`, `audio/matroska`, and `audio/x-matroska` MIME types to `MediaRecorderHandler`. Previously, `video/x-matroska` was partially supported but was internally aliased to `video/mp4` for codec verification. This change removes that alias, allowing Matroska types to be processed natively. The validation logic in `CanSupportVideoType` and `CanSupportAudioType` is updated to accept these new MIME strings. Additionally, `ActualMimeType` is updated to report the correct MIME type instead of defaulting to WebM or MP4 when these types are used. `TrackRecorder` is also updated to map these strings to the `kVideoMatroska` container type. Bug: 40921769 Change-Id: I911784d885d5f65670f080a22001996ac34e2228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit support for
video/matroska,audio/matroska, andaudio/x-matroskaMIME types toMediaRecorderHandler.Previously,
video/x-matroskawas partially supported but wasinternally aliased to
video/mp4for codec verification. This changeremoves that alias, allowing Matroska types to be processed natively.
The validation logic in
CanSupportVideoTypeandCanSupportAudioTypeis updated to accept these new MIME strings. Additionally,
ActualMimeTypeis updated to report the correct MIME type instead ofdefaulting to WebM or MP4 when these types are used.
TrackRecorderisalso updated to map these strings to the
kVideoMatroskacontainertype.
Bug: 40921769
Change-Id: I911784d885d5f65670f080a22001996ac34e2228
Reviewed-on: https://chromium-review.googlesource.com/7262837
WPT-Export-Revision: b4f48a93730602fdd0aaf180ea06611a154c7b87