[Gecko Bug 1817051] Part 3: Start to sample scroll timeline in the HTML loop. #56772
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, we drop ProgressTimelineScheduler since we don't need it anymore. The update in the test is necessary (just like what we do for wpt) for make sure getComputedStyle() works after we sample the scroll timelines, because the updating of stale timelines has no effect on forced style and layout calculations triggered by getComputedStyle() or similar. In other words, initially stale timelines are visible as such through those APIs. Note: there are two new test failures because the timing of caching the current time is later than the moment we trigger the animation and scrollTo API. I will try to fix them in the following patch. In this patch we focus on switching the sampling way and to make sure we don't cause lots of regressions. Differential Revision: https://phabricator.services.mozilla.com/D269666 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1817051 gecko-commit: 239cc012563870819ca11a9eaf5658c4a9090682 gecko-reviewers: firefox-style-system-reviewers, layout-reviewers, hiro, emilio
wpt-pr-bot
approved these changes
Dec 16, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, we drop ProgressTimelineScheduler since we don't need it anymore.
The update in the test is necessary (just like what we do for wpt) for
make sure getComputedStyle() works after we sample the scroll timelines,
because the updating of stale timelines has no effect on forced style and
layout calculations triggered by getComputedStyle() or similar.
In other words, initially stale timelines are visible as such through those
APIs.
Note: there are two new test failures because the timing of caching the
current time is later than the moment we trigger the animation and
scrollTo API. I will try to fix them in the following patch. In this
patch we focus on switching the sampling way and to make sure we don't
cause lots of regressions.
Differential Revision: https://phabricator.services.mozilla.com/D269666
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1817051
gecko-commit: 239cc012563870819ca11a9eaf5658c4a9090682
gecko-reviewers: firefox-style-system-reviewers, layout-reviewers, hiro, emilio