Skip to content

Fix AVIF output format issues#2

Draft
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
avif-output-fix
Draft

Fix AVIF output format issues#2
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
avif-output-fix

Conversation

@google-labs-jules
Copy link

This change fixes the issue where AVIF output format was not working correctly. The issue was caused by packfs.py gzipping .avif files, which led to incorrect Content-Type headers when served. Additionally, the avif MIME type was missing in Mongoose, and caching headers were not being set for AVIF files.

Changes:

  1. SmartEVSE-3/packfs.py: Added .avif to the exclusion list for gzip compression. Generalized the check for .webp files as well.
  2. SmartEVSE-3/src/mongoose.c: Added avif -> image/avif mapping to s_known_types.
  3. SmartEVSE-3/src/network_common.cpp: Added .avif to the list of file extensions that receive long-term cache headers.

PR created automatically by Jules for task 17109649328954087629 started by @webdotpulse

- Modified `SmartEVSE-3/packfs.py` to exclude `.avif` files from gzip compression, as they are already compressed. Also generalized `.webp` exclusion.
- Modified `SmartEVSE-3/src/mongoose.c` to add `image/avif` MIME type.
- Modified `SmartEVSE-3/src/network_common.cpp` to add cache headers for `.avif` files.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants