-
Notifications
You must be signed in to change notification settings - Fork 62
fix(task): OutdialCall CSS #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
mkesavan13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the PR title to reflect the change as the PR title is what sits in the commit history.
akulakum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify which Figma design we are following to address the Outdial component design issue? Also, please attach the corresponding Figma link in the PR description.
rsarika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the PR title and make sure the pipeline successful
|
@brain-frog, the changes look good overall. To fully match the Figma design, the Address Book and Dialpad tab labels are missing, and the Dialpad tab background color needs to be updated. If you have bandwidth, please address these as well so the implementation aligns with Figma.
|
Shreyas281299
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good.
As per the design, we are intentionally not including text for the tabs. However, could we update the background color of the Dialpad tab? The current background does not match the Figma design.
|




COMPLETES https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7509
This pull request addresses
Previous changes to the Outdial Call CSS have misaligned the containers within.
by making the following changes
Adjusting the HTML tags and class usage inside OutdialCall, as well as adding back some CSS properties to containers that lost them.
BEFORE

AFTER

Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.