Skip to content

Conversation

@brain-frog
Copy link
Contributor

@brain-frog brain-frog commented Jan 5, 2026

COMPLETES https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7509

This pull request addresses

Previous changes to the Outdial Call CSS have misaligned the containers within.

by making the following changes

Adjusting the HTML tags and class usage inside OutdialCall, as well as adding back some CSS properties to containers that lost them.

BEFORE
outdial-styling-issues

AFTER
outdial-pr-changes

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-589.d1b38q61t1z947.amplifyapp.com

Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the PR title to reflect the change as the PR title is what sits in the commit history.

@mkesavan13 mkesavan13 added the validated Indicates that the PR is ready for actions label Jan 6, 2026
Copy link
Contributor

@akulakum akulakum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify which Figma design we are following to address the Outdial component design issue? Also, please attach the corresponding Figma link in the PR description.

@brain-frog brain-frog changed the title bug(task): Update OutdialCall CSS bug(task): Fix OutdialCall CSS to be consistent with Desktop visual Jan 6, 2026
@Shreyas281299 Shreyas281299 added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Jan 7, 2026
Copy link
Contributor

@rsarika rsarika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the PR title and make sure the pipeline successful

@brain-frog brain-frog changed the title bug(task): Fix OutdialCall CSS to be consistent with Desktop visual fix(task): OutdialCall CSS Jan 7, 2026
@rsarika rsarika added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Jan 7, 2026
@akulakum
Copy link
Contributor

akulakum commented Jan 8, 2026

@brain-frog, the changes look good overall. To fully match the Figma design, the Address Book and Dialpad tab labels are missing, and the Dialpad tab background color needs to be updated. If you have bandwidth, please address these as well so the implementation aligns with Figma.

Screenshot 2026-01-08 at 10 04 46 AM

Copy link
Contributor

@Shreyas281299 Shreyas281299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.

@akulakum
Copy link
Contributor

@brain-frog, the changes look good overall. To fully match the Figma design, the Address Book and Dialpad tab labels are missing, and the Dialpad tab background color needs to be updated. If you have bandwidth, please address these as well so the implementation aligns with Figma.

Screenshot 2026-01-08 at 10 04 46 AM

As per the design, we are intentionally not including text for the tabs. However, could we update the background color of the Dialpad tab? The current background does not match the Figma design.

Screenshot 2026-01-09 at 10 38 20 AM Screenshot 2026-01-09 at 10 43 39 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants