Fix problems with navigation events that aren't generated by GtkWebKit.#648
Conversation
(used lib: libwebkit2gtk-4.1-0 on linux Mint). The WebKit engine to apparently doesn't catch the navigations and does not produce navigation events, when something like "webui_bind(_webui_win, "", webui_event_handler);" is called. Although this should be expected behaviour. By implementing a handler for the GtkWebKit decision signal, this navigation event can still be generated. Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
|
There are some fails that do not seem to be related to the changes of this pull request. |
Updated the navigation handler function name and its description for clarity.
Yes, this is a Windows workflow fails to find TLS, this because GitHub added Windows Server 2025. I will try to fix it. |
|
@hdijkema I noticed that catching events now have two different functions, one is the regular |
I'm curious how you want to do that. Oh I see. You can of course catch this in the regulare webui_bind() with an empty string. Great. good Idea I think. |
I will use your own GTK code to catch event and sends it to |
Fixed in 63fb9fc |
Fix problems with navigation events that aren't generated by GtkWebKit.
(used lib: libwebkit2gtk-4.1-0 on linux Mint).
The WebKit engine to apparently doesn't catch the navigations and does not produce navigation events, when something like "webui_bind(_webui_win, "", webui_event_handler);" is called. Although this should be expected behaviour.
By implementing a handler for the GtkWebKit decision signal, this navigation event can still be generated.