Skip to content

Fix Flaky Test: getComponent#62

Open
YiweiLi4 wants to merge 1 commit intowebx:masterfrom
YiweiLi4:fix_flaky_test
Open

Fix Flaky Test: getComponent#62
YiweiLi4 wants to merge 1 commit intowebx:masterfrom
YiweiLi4:fix_flaky_test

Conversation

@YiweiLi4
Copy link

The original test uses the toString method to compare the two objects which leads the test to be flaky since the ordering of the string would change and the test would fail even when the two components are equal. To fix this, I extract each element from these two strings, put those elements in two lists, and sort those lists. Then compare the list to check whether those two components are equal.

@leijing1992
Copy link

leijing1992 commented Oct 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments