Add more CLI tests #152

Cube707 · 2025-01-14T21:41:09Z

Fixes #79.

github-actions · 2025-01-14T21:41:59Z

Test Results

48 files ± 0 48 suites ±0 3m 25s ⏱️ +4s
122 tests + 17 122 ✅ + 17 0 💤 ±0 0 ❌ ±0
5 856 runs +816 5 685 ✅ +816 171 💤 ±0 0 ❌ ±0

Results for commit 5e44eef. ± Comparison against base commit 410b987.

This pull request removes 3 and adds 20 tests. Note that renamed tests count towards both.

tests.test_cli ‑ test_verify[data/jenkins.xml-1]
tests.test_cli ‑ test_verify[data/no_fails.xml-0]
tests.test_cli ‑ test_verify[data/normal.xml-1]

tests.test_cli ‑ test_merge
tests.test_cli ‑ test_merge_output_to_terminal
tests.test_cli ‑ test_verify[jenkins.xml-1]
tests.test_cli ‑ test_verify[no_fails.xml-0]
tests.test_cli ‑ test_verify[normal.xml-1]
tests.test_cli ‑ test_verify_with_glob
tests.test_cli.Test_CommandlineOptions ‑ test_help_shows_subcommands
tests.test_cli.Test_CommandlineOptions ‑ test_merge_argument_output
tests.test_cli.Test_CommandlineOptions ‑ test_merge_argument_path
tests.test_cli.Test_CommandlineOptions ‑ test_merge_help_options
…

♻️ This comment has been updated with latest results.

Cube707 · 2025-01-15T16:54:57Z

I updated the testing to use python 3.9

python 3.6, 3.7 and 3.8 are End-Of-Life

Cube707 · 2025-01-15T16:56:21Z

@EnricoMi ready for review now

tests/test_cli.py

weiwei · 2025-01-25T15:23:51Z

.github/workflows/build.yml

      fail-fast: false
      matrix:
-        python-version: ["3.6", "3.x"]
+        python-version: ["3.9", "3.x"]


10+ percent of users are still on older versions so it's probably better to still have some test coverage.

https://pypistats.org/packages/junitparser

Cube707 · 2025-01-25T17:22:41Z

this PR is on hold until #154 is resolved

Cube707 · 2025-01-25T17:30:01Z

#154 once again shows why these tests are needed...

EnricoMi · 2025-02-10T08:25:40Z

@Cube707 please go ahead, #154 is fixed.

the command-parser for the `verify` subcommand is never used directly. But as we might want to expand the parser and for consistency, we want to keep it around

under `lxml` the `encoding` property "UTF-8" is written in capslock, without `lxml` its lowercase. So we ignore that property and only test for the "<?xml version='1.0'" part

Cube707 · 2025-02-10T15:55:44Z

The PR should be ready now and CI passes,

not sure what to do about the codacy issue

EnricoMi · 2025-02-10T16:09:58Z

not sure what to do about the codacy issue

It complains about Unused variable 'verify_parser':
https://app.codacy.com/gh/weiwei/junitparser/pull-requests/152/issues#issue-b00f2d90b386fa0bad7e275a4f7bfd50

Cube707 · 2025-02-11T17:31:01Z

It complains about Unused variable 'verify_parser':

Yeah which I set to be ignored but it only seems to apply to flake8 and I am not sure why two linters are used.

EnricoMi · 2025-02-11T18:07:41Z

junitparser/cli.py


    # command: verify
-    merge_parser = command_parser.add_parser(
+    verify_parser = command_parser.add_parser(  # noqa: F841


I presume the variable is not needed if unused.

Suggested change

verify_parser = command_parser.add_parser( # noqa: F841

command_parser.add_parser(

The verify_parser is still relevant and used and might be modified in the future.

Its variable binding is only unused because it currently only has the attributes inherited from the abstract_parser and no explicit ones of its own.

I believe it should be kept for consistency with the other parsers and to increase the readability for future modifications.

That's why I ignored the warning for flake8

weiwei · 2025-02-16T22:02:09Z

Thanks for the PR.

The codacy config is at the server side so it can't be skipped locally. I've fixed it for you.

Cube707 force-pushed the feat/cli-tests branch 3 times, most recently from 7bef61a to 0af9fee Compare January 15, 2025 16:44

EnricoMi reviewed Jan 16, 2025

View reviewed changes

tests/test_cli.py Outdated Show resolved Hide resolved

EnricoMi changed the title ~~Adding more test for the cli~~ Add more CLI tests Jan 16, 2025

EnricoMi reviewed Jan 16, 2025

View reviewed changes

tests/test_cli.py Outdated Show resolved Hide resolved

Cube707 requested a review from EnricoMi January 17, 2025 13:51

weiwei reviewed Jan 25, 2025

View reviewed changes

Cube707 force-pushed the feat/cli-tests branch 2 times, most recently from f032fec to 2c275c3 Compare January 25, 2025 16:30

Cube707 added 4 commits January 25, 2025 17:41

cli: reduce complexity with path-construction

32b50a6

cli: use an abstract parent parser for shared options

87bc3bf

cli: fix strange handling of args input

9fcf998

cli: add default value for suite_name

f8c7282

Cube707 force-pushed the feat/cli-tests branch from 2c275c3 to 94530a4 Compare February 10, 2025 13:59

Cube707 added 2 commits February 10, 2025 15:18

sync with 'master'

82aca4b

ignore flake8 error

029f0f6

the command-parser for the `verify` subcommand is never used directly. But as we might want to expand the parser and for consistency, we want to keep it around

Cube707 force-pushed the feat/cli-tests branch from 73afb1c to 029f0f6 Compare February 10, 2025 14:18

Cube707 added 6 commits February 10, 2025 15:20

test: use pathlib in cli test

020ea22

test: global constant for data/

c979cc7

test: add cli test for merging

d486449

test: import cli module to avoid to many imports

e12aef9

test: cli option handling

60850fe

test: cli argument parsing

b642f33

Cube707 force-pushed the feat/cli-tests branch from 3d59055 to 71382d1 Compare February 10, 2025 15:26

test: fix cli test which fails only under lxml

416d59a

under `lxml` the `encoding` property "UTF-8" is written in capslock, without `lxml` its lowercase. So we ignore that property and only test for the "<?xml version='1.0'" part

Cube707 force-pushed the feat/cli-tests branch from 6ba43ab to 416d59a Compare February 10, 2025 15:30

test: fix linting issues

5e44eef

Cube707 force-pushed the feat/cli-tests branch from 5550539 to 5e44eef Compare February 10, 2025 15:47

Cube707 requested a review from weiwei February 10, 2025 15:55

EnricoMi reviewed Feb 11, 2025

View reviewed changes

weiwei merged commit bca6112 into weiwei:master Feb 16, 2025
38 checks passed

Cube707 deleted the feat/cli-tests branch February 17, 2025 07:49

	verify_parser = command_parser.add_parser( # noqa: F841
	command_parser.add_parser(

Add more CLI tests #152

Add more CLI tests #152

Uh oh!

Conversation

Cube707 commented Jan 14, 2025 • edited by EnricoMi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Cube707 commented Jan 15, 2025

Uh oh!

Cube707 commented Jan 15, 2025

Uh oh!

Uh oh!

Uh oh!

weiwei Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

Cube707 commented Jan 25, 2025

Uh oh!

Cube707 commented Jan 25, 2025

Uh oh!

EnricoMi commented Feb 10, 2025

Uh oh!

Cube707 commented Feb 10, 2025

Uh oh!

EnricoMi commented Feb 10, 2025

Uh oh!

Cube707 commented Feb 11, 2025

Uh oh!

EnricoMi Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Cube707 Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weiwei commented Feb 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Cube707 commented Jan 14, 2025 •

edited by EnricoMi

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

Cube707 Feb 11, 2025 •

edited

Loading