-
Notifications
You must be signed in to change notification settings - Fork 55
Drop official support for EOL Python versions #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf1a3ed to
6c3e449
Compare
|
|
||
| ## [4.0.0] | ||
| ### Breaking | ||
| - Python 3.8 and earlier are not officially supported, but might still work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this tool is mostly used in infrastructures that doesn't get updated often by the users, and from the download statistics there seem to be still 10% users on versions earlier than 3.9, I'd suggest we hold on a bit until the usage further drops, then we make a clean cut.
Also something released should either work or not, "might work" doesn't sound right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, EOL Python users can continue to use junitparser 3.x.
This change does not break the package for pre-3.9, it only drops guarantees. That is meant by the "might".
We can hold changes (other PRs) that definitively break pre-3.9 versions for some more time and still have this change released. This might help to motivate those 10% users to migrate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ambiguity doesn't sit well with users. The word "might" shouldn't exist in software documentations.
I tend to believe the users are well aware that they're on a dead python version, and they can't update because of certain bigger constraints. Us prodding them to update won't be necessary.
Also we don't really need to drop the guarantee. Our package is simple and we have decent coverage. If the CI continues to pass with Python 3.8, then 3.8 is supported.
Python 2.7 support was dropped 3 years after EOL. For Python 3.8 it shouldn't be that long, but it could be 1 year or 2, I don't know.
6c3e449 to
81237b2
Compare
81237b2 to
01d36e0
Compare
d538fed to
e57975f
Compare
|
We can resurface this when it is time to drop 3.8. |
Mentions in
CHANGELOG.mdandREADME.rstthat EOL Python versions are not supported.