Skip to content

Conversation

@EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Jan 16, 2025

Mentions in CHANGELOG.md and README.rst that EOL Python versions are not supported.

@github-actions
Copy link

github-actions bot commented Jan 16, 2025

Test Results

   48 files  ±0     48 suites  ±0   3m 22s ⏱️ -1s
  103 tests ±0    103 ✅ ±0    0 💤 ±0  0 ❌ ±0 
4 944 runs  ±0  4 773 ✅ ±0  171 💤 ±0  0 ❌ ±0 

Results for commit e57975f. ± Comparison against base commit a094649.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi changed the title Drop EOL Python support Drop EOL Python support, migrate away from legacy setuptools build Jan 16, 2025
@EnricoMi EnricoMi force-pushed the drop-eol-python-support branch 5 times, most recently from cf1a3ed to 6c3e449 Compare January 16, 2025 13:41
@EnricoMi EnricoMi changed the title Drop EOL Python support, migrate away from legacy setuptools build Migrate away from legacy setuptools build Jan 16, 2025

## [4.0.0]
### Breaking
- Python 3.8 and earlier are not officially supported, but might still work.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this tool is mostly used in infrastructures that doesn't get updated often by the users, and from the download statistics there seem to be still 10% users on versions earlier than 3.9, I'd suggest we hold on a bit until the usage further drops, then we make a clean cut.

Also something released should either work or not, "might work" doesn't sound right.

Copy link
Collaborator Author

@EnricoMi EnricoMi Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, EOL Python users can continue to use junitparser 3.x.

This change does not break the package for pre-3.9, it only drops guarantees. That is meant by the "might".

We can hold changes (other PRs) that definitively break pre-3.9 versions for some more time and still have this change released. This might help to motivate those 10% users to migrate.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ambiguity doesn't sit well with users. The word "might" shouldn't exist in software documentations.

I tend to believe the users are well aware that they're on a dead python version, and they can't update because of certain bigger constraints. Us prodding them to update won't be necessary.

Also we don't really need to drop the guarantee. Our package is simple and we have decent coverage. If the CI continues to pass with Python 3.8, then 3.8 is supported.

Python 2.7 support was dropped 3 years after EOL. For Python 3.8 it shouldn't be that long, but it could be 1 year or 2, I don't know.

@EnricoMi EnricoMi force-pushed the drop-eol-python-support branch from 6c3e449 to 81237b2 Compare January 28, 2025 16:25
@EnricoMi EnricoMi changed the title Migrate away from legacy setuptools build Drop official support for EOL Python versions, add integation tests for EOL Python Jan 28, 2025
@EnricoMi EnricoMi force-pushed the drop-eol-python-support branch from 81237b2 to 01d36e0 Compare January 28, 2025 16:35
@EnricoMi EnricoMi force-pushed the drop-eol-python-support branch from d538fed to e57975f Compare January 29, 2025 14:18
@EnricoMi EnricoMi changed the title Drop official support for EOL Python versions, add integation tests for EOL Python Drop official support for EOL Python versions Jan 29, 2025
@EnricoMi
Copy link
Collaborator Author

We can resurface this when it is time to drop 3.8.

@EnricoMi EnricoMi closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants