chore: Add remoteSessionClient.recordings.size config (WH-3717)#115
Merged
danielBWeka merged 2 commits intorelease/v0.4from Feb 3, 2026
Merged
Conversation
danielBWeka
requested review from
Copilot and
vyeveweka
and removed request for
vyeveweka
There was a problem hiding this comment.
Pull request overview
Adds support for configuring remote session recordings PVC size via local config, including validation and Helm values generation.
Changes:
- Introduce
remoteSession.recordings.sizein the v1 local configuration schema with Kubernetes quantity validation. - Generate Helm values for
remoteSessionClient.recordings.sizewhen configured. - Register a new chart values visitor to apply the remote session configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/local/config/v1/v1.go | Adds RemoteSession config structs and validates recordings.size as a Kubernetes quantity. |
| internal/local/chart/v3.go | Emits remoteSessionClient.recordings.size into generated chart values and wires the new visitor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielBWeka
changed the title
ezzadda
approved these changes
Feb 3, 2026
eladda-weka
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.