Skip to content

chore: add shellcheck validation for AI-generated hooks #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caspx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add shellcheck validation for AI-generated hooks #1978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .dagger/src/operator_flows/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,7 @@ async def _get_hook_env_vars(self, test_artifacts: dagger.Directory) -> Dict[str
hooks_container = (
dag.container()
.from_("alpine:latest")
.with_exec(["apk", "add", "--no-cache", "shellcheck", "bash"])
.with_directory("/test_artifacts", test_artifacts)
.with_exec(["tree", "/test_artifacts"])
.with_exec(["sh", "-c", """
Expand All @@ -605,15 +606,24 @@ async def _get_hook_env_vars(self, test_artifacts: dagger.Directory) -> Dict[str
if [ -d "$hook_dir" ]; then
# Extract hook name from directory name (remove "hook_" prefix)
hook_name=$(basename "$hook_dir" | sed 's/^hook_//')

# Check if hook.sh exists
if [ -f "$hook_dir/hook.sh" ]; then
echo "Found hook: $hook_name -> $hook_dir/hook.sh"

# Validate hook script with shellcheck (only fail on errors, not warnings/style)
echo "Validating $hook_dir/hook.sh with shellcheck..."
if ! shellcheck --severity=error "$hook_dir/hook.sh"; then
echo "ERROR: shellcheck validation failed for $hook_dir/hook.sh"
exit 1
fi
echo "shellcheck validation passed for $hook_dir/hook.sh"

hook_env_vars="$hook_env_vars\\n$hook_name=$hook_dir/hook.sh"
fi
fi
done

# Save hook environment variables to a file
echo -e "$hook_env_vars" > /hooks_env_vars.txt
"""])
Expand Down
Loading