Skip to content

fix: refactor hugepages logic to its own file#1998

Open
rugggger wants to merge 1 commit intomainfrom
12-23-fix_refactor_hugepages_logic_to_its_own_file
Open

fix: refactor hugepages logic to its own file#1998
rugggger wants to merge 1 commit intomainfrom
12-23-fix_refactor_hugepages_logic_to_its_own_file

Conversation

@rugggger
Copy link
Contributor

@rugggger rugggger commented Dec 23, 2025

TL;DR

Refactored hugepages handling to skip allocation for driver containers.

What changed?

  • Created a new file internal/controllers/resources/hugepages.go to encapsulate hugepages-related functionality
  • Moved hugepages-related code from pod.go to the new file
  • Added a new setHugePages method that conditionally adds hugepages volume and mount
  • Modified resource allocation to skip hugepages for driver containers
  • Updated pod creation to call setHugePages instead of always including hugepages

Copy link
Contributor Author

rugggger commented Dec 23, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link

graphite-app bot commented Dec 23, 2025

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (12/23/25)

3 reviewers were added to this PR based on Anton Bykov's automation.

@graphite-app graphite-app bot changed the base branch from 12-23-fix_make__lib_modules_directory_overlayfs_over_the_hostpath to graphite-base/1998 December 23, 2025 14:05
@graphite-app graphite-app bot force-pushed the 12-23-fix_refactor_hugepages_logic_to_its_own_file branch from e0125e8 to d526c18 Compare December 23, 2025 14:06
@graphite-app graphite-app bot force-pushed the graphite-base/1998 branch from c5c1b19 to 26b9265 Compare December 23, 2025 14:06
@graphite-app graphite-app bot changed the base branch from graphite-base/1998 to main December 23, 2025 14:06
@graphite-app graphite-app bot force-pushed the 12-23-fix_refactor_hugepages_logic_to_its_own_file branch from d526c18 to 7999d40 Compare December 23, 2025 14:07
@assafgi assafgi requested a review from a team as a code owner January 28, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants