Conversation
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (01/22/26)2 reviewers were added to this PR based on Anton Bykov's automation. |
assafgi
force-pushed
the
01-21-feat_add_smbw_support
branch
from
6660290 to
295e9ec
Compare
| smbwCluster, err := wekaService.GetSmbwCluster(ctx) | ||
| if err != nil { | ||
| err = errors.Wrap(err, "Failed to get SMB-W cluster") | ||
| return err | ||
| } | ||
|
|
||
| if smbwCluster.Active { | ||
| logger.Info("SMB-W cluster already exists") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
it looks like EnsureSmbwCluster expects smbw cluster to be already created and will otherwise
| func contains(s, substr string) bool { | ||
| return len(s) >= len(substr) && (s == substr || len(s) > 0 && containsIgnoreCase(s, substr)) | ||
| } |
There was a problem hiding this comment.
ah, it's for containsIgnoreCase
then maybe would be good to remove this "contains" func and only keep "containsIgnoreCase"
assafgi
force-pushed
the
01-21-feat_add_smbw_support
branch
from
295e9ec to
5516b89
Compare
assafgi
force-pushed
the
01-21-feat_add_smbw_support
branch
12 times, most recently
from
86a2913 to
dd13517
Compare
assafgi
force-pushed
the
01-21-feat_add_smbw_support
branch
from
dd13517 to
607f4de
Compare
2 participants
No description provided.