Implement disabled select styling in bootstrap theme#675
Merged
Conversation
wenzhixin
force-pushed
the
fix/bootstrap-disabled
branch
from
0d0cda0 to
b3ba977
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements disabled select styling for the Bootstrap theme by adding CSS rules for the .disabled state and providing demonstration examples in the theme documentation.
Changes:
- Added CSS variable
--ms-choice-disabled-bgmapped to Bootstrap's--bs-secondary-bg - Implemented
.disabledclass styling with background color, opacity (0.65), and cursor changes - Added two HTML examples: one showing a fully disabled select and another showing individual disabled options
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/themes/bootstrap.scss | Adds disabled state styling with Bootstrap-appropriate background color variable and visual indicators |
| site/website/static/templates/themes.html | Adds demonstration examples for disabled selects and disabled options to showcase the new styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.